fix(terraform-deploy): skip metric for blocked unsafe deployments - #260
Open
stekern wants to merge 1 commit into
Open
fix(terraform-deploy): skip metric for blocked unsafe deployments#260stekern wants to merge 1 commit into
stekern wants to merge 1 commit into
Conversation
The non-trunk-to-prod safety check now runs regardless of trigger and exposes a `__internal-block-unsafe-deployment-result` output so the deployment metric step can skip when the deploy was refused by policy (an expected rejection, not a deploy outcome worth reporting).
yngvark
approved these changes
May 5, 2026
| if: ${{ always() && inputs.send-deployment-metric == 'true' && inputs.datadog-api-key != '' }} | ||
| # Skip when a manual deploy was rejected by policy (e.g., `xx-` artifact to prod): | ||
| # that's an expected refusal, not a deploy outcome we want in the metric. | ||
| if: ${{ always() && steps.block-unsafe-deployment.outputs.result != 'true' && inputs.send-deployment-metric == 'true' && inputs.datadog-api-key != '' }} |
Contributor
There was a problem hiding this comment.
Måtte scrolle opp litt for å forstå steps.block-unsafe-deployment.outputs.result != 'true'.
Så
steps.block-unsafe-deployment.outputs.result != 'true'
kunne vært noe sånt som
steps.block-unsafe-deployment.outputs.blocked != 'true'
eller
steps.block-unsafe-deployment.outputs.blocked == 'false'
for lettere lesbarhet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputs.taginstead ofgithub.event.inputs.artifact-tag, as the latter is only set onworkflow_dispatch), and a test for it